Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] bookstore_mgmt_google_books_api: Fixed book importation for product.product #26

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

BernatObrador
Copy link

Refactored to use a mixin for Google Books API integration. This mixin can now be inherited by both product.template and product.product, enabling proper functionality for both models.

cc https://github.com/APSL 165816

@miquelalzanillas @lbarry-apsl @mpascuall @peluko00 @javierobcn @ppyczko please review

@OCA-git-bot
Copy link
Contributor

Hi @miquelalzanillas, @peluko00,
some modules you are maintaining are being modified, check this out!

@BernatObrador BernatObrador force-pushed the 17.0-fix-bookstore_mgmt_google_books_api branch 3 times, most recently from 7ec32a2 to 0807fe4 Compare January 16, 2025 09:09
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peluko00
Copy link

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-26-by-peluko00-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 16, 2025
Signed-off-by peluko00
@OCA-git-bot
Copy link
Contributor

@peluko00 your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-26-by-peluko00-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

…duct.product

Refactored to use a mixin for Google Books API integration. This mixin can now be inherited by both product.template and product.product,  enabling proper functionality for both models.
@BernatObrador BernatObrador force-pushed the 17.0-fix-bookstore_mgmt_google_books_api branch from 0807fe4 to e6a9d3e Compare January 16, 2025 10:13
@peluko00
Copy link

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-26-by-peluko00-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2a77f07 into OCA:17.0 Jan 16, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ba91edb. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants