Skip to content

[MIG] web_save_discard_button: Migration to 18.0 #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: 18.0
Choose a base branch
from
Open

[MIG] web_save_discard_button: Migration to 18.0 #3239

wants to merge 8 commits into from

Conversation

julienCozo
Copy link

Migration to 18.0

@pedrobaeza
Copy link
Member

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

@julienCozo julienCozo force-pushed the 18.0-mig-web-save-discard-button branch from 5b80b1b to d6b1104 Compare August 4, 2025 14:15
@julienCozo
Copy link
Author

Hello @pedrobaeza ,
My bad, it should be nice now.
Thank you

@pedrobaeza
Copy link
Member

/ocabot migration web_save_discard_button

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Aug 4, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Aug 4, 2025
Open
45 tasks
remi-filament
remi-filament approved these changes Aug 4, 2025
View reviewed changes
Copy link
Contributor

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @julienCozo tested OK on Runboat

@innovara
Copy link

innovara commented Sep 5, 2025

Functional tests are okay for me but there are still a number of references to 17.0 particularly in web_save_discard_button/static/description/index.html and web_save_discard_button/README.rst.
I've done a migration myself but it wouldn't be appropriate to open another PR. See here: https://github.com/innovara/web/tree/18.0-mig-web_save_discard_button

@julienCozo
Copy link
Author

thank you @innovara. I made the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@remi-filament remi-filament remi-filament approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
18.0
Development

Successfully merging this pull request may close these issues.
10 participants
@julienCozo @pedrobaeza @innovara @remi-filament @OCA-git-bot @sam-synconics @legalsylvain @Ivorra78 @mymage @joepsanders