Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14][IMP] shopfloor: Ensure destination location on moves for allow move create #973

Open
wants to merge 2 commits into
base: 14.0
Choose a base branch
from

Conversation

mt-software-de
Copy link
Contributor

@mt-software-de mt-software-de commented Jan 15, 2025

Ensure that the destination gets also set on the move. When a move is created within the single pack or single product transfer scenario, the move ends up with the default destination location of the operation type.
To ensure that the destination location of the move gets also set, we need to set it also on the move not only on the move.line.

cc @jbaudoux @i-vyshnevska

@OCA-git-bot
Copy link
Contributor

Hi @mmequignon, @simahawk, @sebalix, @guewen,
some modules you are maintaining are being modified, check this out!

@mt-software-de mt-software-de force-pushed the 14-shopfloor-refactor-write_destination branch from 9dba5df to b6e7746 Compare January 15, 2025 15:24
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of sync_src_location ?

@mt-software-de mt-software-de force-pushed the 14-shopfloor-refactor-write_destination branch from b6e7746 to 9dc0af0 Compare January 15, 2025 15:43
@mt-software-de
Copy link
Contributor Author

What's the purpose of sync_src_location ?
I updated the description.

@mt-software-de mt-software-de force-pushed the 14-shopfloor-refactor-write_destination branch from 9dc0af0 to 4ad6e2e Compare January 15, 2025 16:14
@jbaudoux
Copy link
Contributor

Without syncing the src location, the moves will end up with the warehouse view location as src location and with actual scanned location as dest location.

@mt-software-de Isn't it something that should be tackled at move creation? When you scan the source location and product/package to move, the move should be created on that location and not on the picking type source location. Same if you plan the moves, should be planned on the right source location.

@mt-software-de mt-software-de force-pushed the 14-shopfloor-refactor-write_destination branch from 4ad6e2e to a424e8b Compare January 17, 2025 14:51
@mt-software-de mt-software-de changed the title [14][IMP] shopfloor: Sync source location on single product and single pack transfer [14][IMP] shopfloor: Ensures destination location on allow move create Jan 21, 2025
@mt-software-de mt-software-de changed the title [14][IMP] shopfloor: Ensures destination location on allow move create [14][IMP] shopfloor: Ensure destination location on moves for allow move create Jan 21, 2025
@mt-software-de
Copy link
Contributor Author

Without syncing the src location, the moves will end up with the warehouse view location as src location and with actual scanned location as dest location.

@mt-software-de Isn't it something that should be tackled at move creation? When you scan the source location and product/package to move, the move should be created on that location and not on the picking type source location. Same if you plan the moves, should be planned on the right source location.

I checked it again the source location was never be the problem. I was on allow move create the dest location on the move which was missing. And only for the single product transfer because there are no package level.

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking better. Just a few left overs

@jbaudoux
Copy link
Contributor

cc @rousseldenis

@mt-software-de mt-software-de force-pushed the 14-shopfloor-refactor-write_destination branch from a424e8b to 9acedea Compare January 21, 2025 10:07
@jbaudoux jbaudoux requested a review from mmequignon January 29, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants