chore(BV, CP): Refactor propagation mechanism #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclement-ocp
force-pushed
the
better-prop
branch
8 times, most recently
from
f61432e
to
9efef42
Compare
Halbaroth
requested changes
Aug 16, 2024
bclement-ocp
force-pushed
the
better-prop
branch
from
9efef42
to
e0c187b
Compare
|
Please rebase and we can merge :) |
This patch simplifies the propagation mechanism (currently used in the bit-vector relations only) in order to accomodate different types of propagators more easily. In particular, there is now a single generic (and configurable) loop that runs the propagators instead of a spaghetti of different loops for each kind of propagators.
bclement-ocp
force-pushed
the
better-prop
branch
from
ddeb599
to
6007321
Compare
Halbaroth
approved these changes
Aug 20, 2024
bclement-ocp
added a commit
to bclement-ocp/alt-ergo
that referenced
this pull request
Aug 28, 2024
Since OCamlPro#1185, when substitutions change the domain of a variable, we no longer trigger propagations, which means that we can end up in a state where the bitlist and interval domains are not consistent (i.e. running [constrain_bitlist_from_interval] or [constrain_interval_from_bitlist] would shrink some domains). This was initially part of OCamlPro#1185 but was accidentally removed as part of a simplification pass during review. Add it back.
bclement-ocp
added a commit
that referenced
this pull request
Aug 28, 2024
Since #1185, when substitutions change the domain of a variable, we no longer trigger propagations, which means that we can end up in a state where the bitlist and interval domains are not consistent (i.e. running [constrain_bitlist_from_interval] or [constrain_interval_from_bitlist] would shrink some domains). This was initially part of #1185 but was accidentally removed as part of a simplification pass during review. Add it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch simplifies the propagation mechanism (currently used in the
bit-vector relations only) in order to accomodate different types of
propagators more easily.
In particular, there is now a single generic (and configurable) loop
that runs the propagators instead of a spaghetti of different loops for
each kind of propagators.
Note: This PR depends on and includes #1152 and #1154. Only the commit titled "chore(BV, CP): Refactor propagation mechanism" (and later commits) are part of this PR.