Use logs in Adt_rel
#1207
Merged
Use logs in Adt_rel
#1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Halbaroth
force-pushed
the
use-logs-adt
branch
from
eea1760
to
539dfa4
Compare
bclement-ocp
requested changes
Aug 19, 2024
src/lib/reasoners/adt_rel.ml
Outdated
| "%a" X.print r | ||
|
|
||
| let assume l = | ||
| Logs.debug ~src:Sources.adt_rel |
There was a problem hiding this comment.
Please don't use Logs.debug ~src:.... Instead, define module Log = (val Logs.src_log Sources.adt_rel) at the top of the file, and use Log.debug directly. See the example from Logs's documentation.
| let pp_domains loc domains = | ||
| if Options.get_debug_adt () then begin | ||
| print_dbg ~flushed:false ~module_name:"Adt_rel" | ||
| "@[<v 2>--ADT env %s ---------------------------------@ " loc; |
There was a problem hiding this comment.
Looks like this PR removes the the --- separators that can make the logs more readable; is that intentional?
There was a problem hiding this comment.
It is intentional because Logs uses correctly indentations. So we will get something like that:
[DEBUG][Adt_rel] environment before assume:
the environment here
....
[DEBUG][Adt_rel] ...
The indentation makes clear in which messages we are.
Halbaroth
force-pushed
the
use-logs-adt
branch
2 times, most recently
from
2799f7f
to
17847a7
Compare
bclement-ocp
approved these changes
Aug 22, 2024
Halbaroth
force-pushed
the
use-logs-adt
branch
from
17847a7
to
2828de1
Compare
|
Actually I already rebased it and I expected that github will skip empty commit. I rebased it again to be sure but now the CI is dead :D (it is not our fault). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is rebased on #1204 and #1206