Use an exception to leave Solving_loop.process_source.
#1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Halbaroth
force-pushed
the
support-exit-on-error-js
branch
from
3ea8cfc
to
721ef01
Compare
This function cannot call the system call `exit` because this system call is not supported in browsers (it works in Node). This commit uses a new exception `Exit_on_error` and catch it at the toplevel of binaries.
bclement-ocp
approved these changes
Oct 9, 2024
src/bin/common/solving_loop.ml
Outdated
| @@ -32,6 +32,8 @@ module DO = D_state_option | |||
| module Sy = Symbols | |||
| module O = Options | |||
|
|
|||
| exception Exit_on_error of int | |||
There was a problem hiding this comment.
This is also used to exit with a return code of 0, which is not an error — I'd suggest renaming it to Exit_with_code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function cannot call the system call
exitbecause this system call is not supported in browsers (it works in Node).This commit uses a new exception
Exit_on_errorand catch it at the toplevel of binaries.Solve issue #1250
I didn't create a new error in
Errorsbecause these errors are caught inSolving_loopto raiseExit_on_error.