Run tests with dolmen by default #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We plan on making dolmen the default frontend in the near future, so it onyl makes sense that we actually start testing dolmen more. This also simplifies slightly the handling of the 'dolmen' modifier, since it only means that we must exclude the 'legacy' case now. This also simplifies the test generation a bit by including the runtest and runtest-quick targets on the CI, which means we don't need duplicates for `tableaux` and `tableaux_ci`, etc anymore.
hra687261
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We plan on making dolmen the default frontend in the near future, so it onyl makes sense that we actually start testing dolmen more.
This also simplifies slightly the handling of the 'dolmen' modifier, since it only means that we must exclude the 'legacy' case now.
This also simplifies the test generation a bit by including the runtest and runtest-quick targets on the CI, which means we don't need duplicates for
tableauxandtableaux_ci, etc anymore.Note: the CI is expected to fail due to #734