-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary fix of issue 744 #747
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclement-ocp
requested changes
Jul 24, 2023
src/lib/frontend/d_cnf.ml
Outdated
Comment on lines
1089
to
1090
This code will be removed as soon as the next version of | ||
Dolmen has been released. *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make an AE issue for this and reference it here.
Halbaroth
force-pushed
the
temporary-fix-744
branch
from
July 24, 2023 16:20
2befa3b
to
6672c1a
Compare
Is it ok? |
Plase add a link to #748 in the comment. |
bclement-ocp
approved these changes
Jul 25, 2023
Halbaroth
added a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Jun 18, 2024
The new version of Dolmen has been released yesterday! This commit updates the lock file and remove the hotfix for the issue OCamlPro#747 as the appropriate fix in included in the last release of Dolmen.
Halbaroth
added a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Jun 18, 2024
The new version of Dolmen has been released yesterday! This commit updates the lock file and remove the hotfix for the issue OCamlPro#747 as the appropriate fix in included in the last release of Dolmen.
Halbaroth
added a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Jun 18, 2024
The new version of Dolmen has been released yesterday! This commit updates the lock file and remove the hotfix for the issue OCamlPro#747 as the appropriate fix is included in the last release of Dolmen.
Halbaroth
added a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Jun 18, 2024
The new version of Dolmen has been released yesterday! This commit updates the lock file and remove the hotfix for the issue OCamlPro#747 as the appropriate fix is included in the last release of Dolmen.
Halbaroth
added a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Jul 8, 2024
The new version of Dolmen has been released yesterday! This commit updates the lock file and remove the hotfix for the issue OCamlPro#747 as the appropriate fix is included in the last release of Dolmen.
Halbaroth
added a commit
that referenced
this pull request
Jul 9, 2024
* Bump the version of Dolmen to 0.10 The new version of Dolmen has been released yesterday! This commit updates the lock file and remove the hotfix for the issue #747 as the appropriate fix is included in the last release of Dolmen. * Dolmen 0.10 @ nix --------- Co-authored-by: Basile Clément <[email protected]>
Halbaroth
added a commit
to Halbaroth/alt-ergo
that referenced
this pull request
Jul 24, 2024
* Bump the version of Dolmen to 0.10 The new version of Dolmen has been released yesterday! This commit updates the lock file and remove the hotfix for the issue OCamlPro#747 as the appropriate fix is included in the last release of Dolmen. * Dolmen 0.10 @ nix --------- Co-authored-by: Basile Clément <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR displays an appropriate error message when an ill-typed is produced by the Dolmen frontend.
The issue has been fixed on the master branch of Dolmen. Thus, this fix will be reverted when the next release of Dolmen will be released.