Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary fix of issue 744 #747

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Conversation

Halbaroth
Copy link
Collaborator

This PR displays an appropriate error message when an ill-typed is produced by the Dolmen frontend.
The issue has been fixed on the master branch of Dolmen. Thus, this fix will be reverted when the next release of Dolmen will be released.

@Halbaroth Halbaroth added this to the 2.5.0 milestone Jul 24, 2023
@Halbaroth Halbaroth linked an issue Jul 24, 2023 that may be closed by this pull request
Comment on lines 1089 to 1090
This code will be removed as soon as the next version of
Dolmen has been released. *)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make an AE issue for this and reference it here.

@Halbaroth
Copy link
Collaborator Author

Is it ok?

@bclement-ocp
Copy link
Collaborator

Plase add a link to #748 in the comment.

@Halbaroth Halbaroth merged commit 47b7923 into OCamlPro:next Jul 25, 2023
10 checks passed
Halbaroth added a commit to Halbaroth/alt-ergo that referenced this pull request Jun 18, 2024
The new version of Dolmen has been released yesterday!
This commit updates the lock file and remove the hotfix for the
issue OCamlPro#747 as the appropriate
fix in included in the last release of Dolmen.
Halbaroth added a commit to Halbaroth/alt-ergo that referenced this pull request Jun 18, 2024
The new version of Dolmen has been released yesterday!
This commit updates the lock file and remove the hotfix for the
issue OCamlPro#747 as the appropriate
fix in included in the last release of Dolmen.
Halbaroth added a commit to Halbaroth/alt-ergo that referenced this pull request Jun 18, 2024
The new version of Dolmen has been released yesterday!
This commit updates the lock file and remove the hotfix for the
issue OCamlPro#747 as the appropriate
fix is included in the last release of Dolmen.
Halbaroth added a commit to Halbaroth/alt-ergo that referenced this pull request Jun 18, 2024
The new version of Dolmen has been released yesterday!
This commit updates the lock file and remove the hotfix for the
issue OCamlPro#747 as the appropriate
fix is included in the last release of Dolmen.
Halbaroth added a commit to Halbaroth/alt-ergo that referenced this pull request Jul 8, 2024
The new version of Dolmen has been released yesterday!
This commit updates the lock file and remove the hotfix for the
issue OCamlPro#747 as the appropriate
fix is included in the last release of Dolmen.
Halbaroth added a commit that referenced this pull request Jul 9, 2024
* Bump the version of Dolmen to 0.10

The new version of Dolmen has been released yesterday!
This commit updates the lock file and remove the hotfix for the
issue #747 as the appropriate
fix is included in the last release of Dolmen.

* Dolmen 0.10 @ nix

---------

Co-authored-by: Basile Clément <[email protected]>
Halbaroth added a commit to Halbaroth/alt-ergo that referenced this pull request Jul 24, 2024
* Bump the version of Dolmen to 0.10

The new version of Dolmen has been released yesterday!
This commit updates the lock file and remove the hotfix for the
issue OCamlPro#747 as the appropriate
fix is included in the last release of Dolmen.

* Dolmen 0.10 @ nix

---------

Co-authored-by: Basile Clément <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on too long extraction
2 participants