Propagate equalities within int2bv #749
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds some reasoning support in bitv_rel for equalities and disequalities between `int2bv` terms. More specifically, when an equality or disequality (~ stands for either `=` or `distinct`): `(~ ((_ int2bv n) t) ((_ int2bv n) u))` is asserted, we also assert that `t` and `u` are congruent (resp. noncongruence) modulo `2^n`, i.e. `(~ (mod (- t u) (pow 2 n)) 0)` This allows recovering some reasoning power involving bitvector terms containing `int2bv`, and in particular terms involving bitvector arithmetic (since bitvector arithmetic is currently implemented using `int2bv`).
|
Draft because I need to re-run benches on this. |
|
This is +40-0 on smtlib22/QF_BV. Not sure I want to nominate this for 2.5.0, it's nice to have but not necessary so we can postpone (but I had it laying around so might as well make the PR). |
|
Let's postpone it. |
|
Following my investigations for #474 and #801 I have a better understanding of the type of equalities we see in relations, and in its current instantiation, this is not a general solution and will only propagate |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds some reasoning support in bitv_rel for equalities and disequalities between
int2bvterms. More specifically, when an equality or disequality (~ stands for either=ordistinct):(~ ((_ int2bv n) t) ((_ int2bv n) u))is asserted, we also assert that
tanduare congruent (resp. noncongruence) modulo2^n, i.e.(~ (mod (- t u) (pow 2 n)) 0)This allows recovering some reasoning power involving bitvector terms containing
int2bv, and in particular terms involving bitvector arithmetic (since bitvector arithmetic is currently implemented usingint2bv).