Issue 705 #755
Merged
Issue 705 #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclement-ocp
requested changes
Jul 26, 2023
src/lib/structures/modelMap.ml
Outdated
| | "@/" | "@%" | "@*" -> true | ||
| | _ -> false | ||
|
|
||
| (* The model generation is not ready for FPA and Bitvector theories. *) |
There was a problem hiding this comment.
s/not ready/known to be incomplete
There was a problem hiding this comment.
Please don't resolve conversations asking for a change without making the corresponding change.
There was a problem hiding this comment.
Sorry, I thought I did it.
|
Done |
This reverts commit 8ff2268.
bclement-ocp
approved these changes
Jul 26, 2023
| if ModelMap.(is_suspicious functions || is_suspicious constants | ||
| || is_suspicious arrays) then | ||
| Format.fprintf fmt "; This model is a best-effort. It includes symbols | ||
| for which model generation is known to be incomplete. @."; |
There was a problem hiding this comment.
I don't think we should be flushing the printer here, @, would be preferrable, but I am not sure we are in a box here, so let's leave it that way for now.
src/lib/structures/modelMap.ml
Outdated
| | "@/" | "@%" | "@*" -> true | ||
| | _ -> false | ||
|
|
||
| (* The model generation is not ready for FPA and Bitvector theories. *) |
There was a problem hiding this comment.
Please don't resolve conversations asking for a change without making the corresponding change.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #705.