Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links in odoc mld files #756

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

bclement-ocp
Copy link
Collaborator

Nominating for 2.5.0 @Halbaroth

@Halbaroth
Copy link
Collaborator

Can I merge it on next before merging the PR #754 ?

@bclement-ocp bclement-ocp added this to the 2.5.0 milestone Jul 26, 2023
@bclement-ocp
Copy link
Collaborator Author

Sure, it's probably easier -- but as soon as the PR exists I think we need to be careful with what we merge or not
(actually now that I think of it is is an issue of the process as described, the state between the creation of the PR and the merge of the PR is a bit fuzzy in practice... We should probably say that the branch is created off from the PR commit before the merge, so that things that get into next while the branch PR is under review don't go into the release by mistake)

@Halbaroth
Copy link
Collaborator

Ok, I will merge the release PR first.

@bclement-ocp
Copy link
Collaborator Author

Hm not sure I follow -- either we tag after the merge and we should merge this (and #757 I suppose) before the 2.5.0 PR, or we tag before the merge and it doesn't matter, I think?

@Halbaroth
Copy link
Collaborator

My plan is to merge #754, then create the tag and the branch of the release and merge on next and backport on 2.5.x this PR after.

@Halbaroth Halbaroth merged commit 4d11f96 into OCamlPro:next Jul 26, 2023
10 checks passed
@Halbaroth Halbaroth mentioned this pull request Jul 26, 2023
@bclement-ocp bclement-ocp deleted the bclement/mld branch January 3, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants