Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: adding minimal build #184

Merged
merged 1 commit into from
Sep 27, 2024
Merged

CI: adding minimal build #184

merged 1 commit into from
Sep 27, 2024

Conversation

GitMensch
Copy link
Collaborator

@GitMensch GitMensch commented Sep 27, 2024

as mentioned in #177

additional:

  • added NIST85 summary and duration files to the NIST result artifact
  • adjust artifact names to prevent conflicts

* based on CI-Dstribution, using download-artifact

additional:
* added NIST85 summary and duration files to the NIST result artifact
* adjust artifact names to prevent conflicts
Copy link
Collaborator Author

@GitMensch GitMensch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result LGTM now, so just waiting for a second look.

Note: I haven't checked if we may optimize the long running MSYS workflows (we could, for example, also use the CI tarball generated here, if that helps - but that would need to be a bit adjusted - still possible)

Note: we should try to use https://github.com/marketplace/actions/skip-duplicate-actions, this will prevent up-to-date source branches to run both push+pull workflows (because in this case the second has identical files; it would still run if the base is older as the merge result would then have a different hash / file content)

Copy link
Contributor

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, I had a quick look as well.

@GitMensch GitMensch merged commit 482206f into gcos4gnucobol-3.x Sep 27, 2024
27 of 28 checks passed
@GitMensch GitMensch deleted the ci-minimal-build branch September 27, 2024 19:33
@ddeclerck
Copy link
Contributor

Was late on this one, but LGTM ;)

Note: I haven't checked if we may optimize the long running MSYS workflows (we could, for example, also use the CI tarball generated here, if that helps - but that would need to be a bit adjusted - still possible)

Regarding this issue, it occurs randomly (but often) ; could it be a locking issue ?

@GitMensch
Copy link
Collaborator Author

GitMensch commented Sep 28, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants