-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: adding minimal build #184
Conversation
930156a
to
d772b38
Compare
* based on CI-Dstribution, using download-artifact additional: * added NIST85 summary and duration files to the NIST result artifact * adjust artifact names to prevent conflicts
d772b38
to
e3283da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result LGTM now, so just waiting for a second look.
Note: I haven't checked if we may optimize the long running MSYS workflows (we could, for example, also use the CI tarball generated here, if that helps - but that would need to be a bit adjusted - still possible)
Note: we should try to use https://github.com/marketplace/actions/skip-duplicate-actions, this will prevent up-to-date source branches to run both push+pull workflows (because in this case the second has identical files; it would still run if the base is older as the merge result would then have a different hash / file content)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just in case, I had a quick look as well.
Was late on this one, but LGTM ;)
Regarding this issue, it occurs randomly (but often) ; could it be a locking issue ? |
I guess that's a locking issue on the underlying MS Windows OS, if you use multiple jobs it is much more easy to reproduce...
Concerning the other current PR with the build system update ... I've just recognized that most of the appveyor CI is broken now as many seem to run with autoconf 2.69 or older, here it is only the MSYS1 version (which I had expected). So I'll inspect that first...
|
as mentioned in #177
additional: