reviews not exists file call

OCamlPro · Jan 8, 2024 · 1db0002 · 1db0002
1 parent f4128ac
commit 1db0002
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 17 deletions.
diff --git a/src/cmd_opt.ml b/src/cmd_opt.ml
@@ -6,7 +6,7 @@ open Syntax
 
 let optimize_file ~unsafe filename =
   if not @@ Sys.file_exists filename then
-    error_s "Error: file `%s` doesn't exist" filename
+    error_s "file `%s` doesn't exist" filename
   else
     let* modul = Parse.Module.from_file ~filename in
     Compile.until_optimize ~unsafe ~optimize:true modul

diff --git a/test/optimize/dune b/test/optimize/dune
@@ -12,7 +12,6 @@
   ibinop.wast
   if.wast
   local.wast
-  not_exists.wast
   ref_nop.wast
   reinterpret.wast
   relop_testop.wast

diff --git a/test/optimize/not_exists.t b/test/optimize/not_exists.t
@@ -1,4 +1,4 @@
-not exists file (exists_not.wast instead of not_exists.wast):
-  $ dune exec -- owi opt exists_not.wast --debug
-  Error: file `exists_not.wast` doesn't exist
+file doesn't exist:
+  $ dune exec -- owi opt not_exists.wast --debug
+  file `not_exists.wast` doesn't exist
   [1]
diff --git a/test/optimize/not_exists.wast b/test/optimize/not_exists.wast
diff --git a/test/optimize/not_exists_script.t b/test/optimize/not_exists_script.t
@@ -0,0 +1,4 @@
+file doesn't exist (script option):
+  $ dune exec -- owi script not_exists.wast --debug --profiling
+  file `not_exists.wast` doesn't exist
+  [1]
diff --git a/test/sym/dune b/test/sym/dune
@@ -2,5 +2,4 @@
  (deps
   %{bin:owi}
   mini_test.wast
-  not_exists.wast
  ))
diff --git a/test/sym/not_exists.t b/test/sym/not_exists.t
@@ -1,4 +1,4 @@
-not exists file (exists_not.wast instead of not_exists.wast):
-  $ dune exec owi -- sym exists_not.wast
-  Error: file `exists_not.wast` doesn't exist
+file doesn't exist:
+  $ dune exec owi -- sym not_exists.wast
+  Error: file `not_exists.wast` doesn't exist
   [1]
diff --git a/test/sym/not_exists.wast b/test/sym/not_exists.wast