Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix CI by Installing rust-wasm #497

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

filipeom
Copy link
Collaborator

No description provided.

@filipeom filipeom marked this pull request as draft February 10, 2025 19:59
@filipeom filipeom marked this pull request as ready for review February 10, 2025 20:51
@filipeom
Copy link
Collaborator Author

The ubuntu CI seems to be ok. Failing on linter, but this is already fixed in #494.

The macos CI is failing on an expect test because previously the c compilar was only named clang and now it's clang-15.

@zapashcanon
Copy link
Member

zapashcanon commented Feb 10, 2025

Actually, I already opened #490 that depends on ocaml/opam-repository#27381 ; I expect to progress on both of them in a few days but I'm fine about merging this now.

The macos CI is failing on an expect test because previously the c compilar was only named clang and now it's clang-15.

Hum this is annoying... Maybe it is simply that we're not installing the latest version but clang-15 that is not the latest anymore and is thus not symlinked to clang?

@filipeom
Copy link
Collaborator Author

Actually, I already opened #490 that depends on ocaml/opam-repository#27381 ; I expect to progress on both of them in a few days but I'm fine about merging this now.

Ah yes, I had seen this but I forgot 😅. Maybe we can drop this PR then since I don't think any of us actively needs CI atm.

Hum this is annoying... Maybe it is simply that we're not installing the latest version but clang-15 that is not the latest anymore and is thus not symlinked to clang?

That is the most likely cause I believe. But we could probably delete the line in the test to make it pass. (Something like ... | sed '/clang\(-1[5-9]*\)\?: error: linker command failed with exit code 1 (use -v to see invocation)/d')

@zapashcanon
Copy link
Member

Oh, I thought the executable was not found because of the new name. If it is simply displayed differently, indeed, we can suppress the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants