Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dump and listing files #347

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

nberth
Copy link
Collaborator

@nberth nberth commented Aug 7, 2024

Closes #328 & #348

@nberth nberth marked this pull request as ready for review August 7, 2024 11:46
@GitMensch
Copy link

Does this include the use of the LSP on those (outline based on this file only)? Otherwise this may only be a partial solve of the referenced issue.

@nberth
Copy link
Collaborator Author

nberth commented Aug 7, 2024

Does this include the use of the LSP on those (outline based on this file only)? Otherwise this may only be a partial solve of the referenced issue.

Not yet, this is only preliminary support; I'll add a separate issue for the outline.

This brings every navigation and edition feature for these files
@nberth nberth linked an issue Aug 7, 2024 that may be closed by this pull request
@nberth
Copy link
Collaborator Author

nberth commented Aug 7, 2024

Does this include the use of the LSP on those (outline based on this file only)? Otherwise this may only be a partial solve of the referenced issue.

Not yet, this is only preliminary support; I'll add a separate issue for the outline.

Actually that was much more easy to do than I anticipated ;-)

@nberth
Copy link
Collaborator Author

nberth commented Aug 7, 2024

@GitMensch Note: this currently hardcodes the format for listing and dump files to an equivalent of -fformat=VARIABLE. If such files may include lines longer than 250 chars, then maybe we'd need another source-format similar to FIXED with with no right margin.

@nberth nberth merged commit e15eab4 into OCamlPro:master Aug 7, 2024
4 checks passed
@nberth nberth deleted the list-n-dump-files branch August 7, 2024 13:36
@GitMensch
Copy link

GitMensch commented Aug 7, 2024 via email

@GitMensch
Copy link

GitMensch commented Aug 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an outline for listing and dump files FR: add support for dump and list files
3 participants