Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for textDocument/rename #351

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Support for textDocument/rename #351

merged 8 commits into from
Aug 14, 2024

Conversation

NeoKaios
Copy link
Contributor

Closes #341

@NeoKaios
Copy link
Contributor Author

This needs the fix from #349 to allow proper rename of procedure

@NeoKaios NeoKaios marked this pull request as ready for review August 13, 2024 08:17
nberth
nberth reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some improvements may be needed, especially about error handling.

test/lsp/lsp_rename.ml Outdated Show resolved Hide resolved
test/lsp/lsp_rename.ml Outdated Show resolved Hide resolved
src/lsp/cobol_lsp/lsp_request.ml Outdated Show resolved Hide resolved
src/lsp/cobol_lsp/lsp_request.ml Outdated Show resolved Hide resolved
src/lsp/cobol_lsp/lsp_request.ml Outdated Show resolved Hide resolved
src/lsp/cobol_lsp/lsp_server.ml Outdated Show resolved Hide resolved
src/lsp/cobol_lsp/lsp_server.ml Outdated Show resolved Hide resolved
src/lsp/cobol_lsp/lsp_request.ml Outdated Show resolved Hide resolved
nberth
nberth reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I guess we can merge once an entry "Support for Rename Symbol command" is added to the CHANGELOG.

@NeoKaios
feat: added qualificators to data and proc refs
1d1d255 
this fixes rename on parent field
nberth
nberth reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@nberth nberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK modulo a styling issue.

src/lsp/cobol_typeck/typeck_procedure.ml Outdated Show resolved Hide resolved
nberth
nberth reviewed Aug 14, 2024
View reviewed changes
test/lsp/lsp_rename.ml Outdated Show resolved Hide resolved
nberth
nberth reviewed Aug 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
nberth
nberth reviewed Aug 14, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nberth nberth merged commit 16d6ee8 into OCamlPro:master Aug 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nberth nberth nberth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provide refactor->rename for procedures and variables
2 participants
@NeoKaios @nberth