-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for COBOL CFG display with graphviz
and d3
#368
base: master
Are you sure you want to change the base?
Conversation
fix package.json
d041e89
to
6594f5c
Compare
- isolated CFG_options module, add mli for Cfg_builder - improve desc of commands - Ensure no silent error on asset file reading - add new cfg_type for clarity
- add history to go back to previous graphs
assets/cfg-d3-renderer.html
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure to see what .html
file in assets
is actually used: could you add a comment in them to describe what they are used for? Also they possibly need a license header (at least those with code I think).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which one ? OCAMLPRO-NON-COMMERCIAL license ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only skimmed through this file, which appears fine as a draft. Some changes will be needed (possibly later) to avoid doing the actual export in this library (which should mostly be about internal CFG representation and construction, with possibly a Cobol_cfg.As_dot
module which may be helpful in other contexts).
ocaml-graph
dependency to generated a dot graph of the CFG of a COBOL program / section