-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SQL preprocessor #370
base: master
Are you sure you want to change the base?
Add SQL preprocessor #370
Conversation
- fix sql stmt generation when stmt is exactly 72 char long - unify prefix on all preproc genereted lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think we are close to merging this PR; just minor details to address. (I won't review the contents of sql_preproc
though… wouldn't want to have to edit that code 😅 ).
src/lsp/sql_preproc/data_gestion.ml
Outdated
?(ind_addr = 0) map name = | ||
StringMap.add name { length; vartype; scale; flags; ind_addr } map | ||
|
||
let num = ref 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😿
Good luck! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a funny diff ;-)
An up-to-date with master version of #307
Also contains various bugfixes found while launching Gixsql testsuite