Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package name in build scripts #9

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Fix package name in build scripts #9

merged 1 commit into from
Sep 4, 2023

Conversation

nberth
Copy link
Collaborator

@nberth nberth commented Jul 13, 2023

No description provided.

emilienlemaire
emilienlemaire approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@emilienlemaire emilienlemaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, I thought I already changed those 😅
Ok to merge after CI passed 👍

@nberth
Copy link
Collaborator Author

nberth commented Jul 13, 2023 •
edited
Loading

Actually what is the CI doing? Is it supposed to reach the make compile stage? (That's where that broke for me.)

@emilienlemaire
Copy link
Contributor

As of now it just does a drom build, but that has been useful to check if everything compiled well on windows

@nberth
Copy link
Collaborator Author

nberth commented Jul 13, 2023

Do you think it's relevant to complete the build process in the CI (with yarn and all)?

@emilienlemaire
Copy link
Contributor

It would be for deployment maybe, to generate the .vsix file automatically, but for now it will just slow down the CI which is already not that fast

@nberth
Copy link
Collaborator Author

nberth commented Jul 13, 2023

Ok, for a deployment test maybe. That was just to check what the CI is used for.

@nberth nberth merged commit 0d266ec into OCamlPro:master Sep 4, 2023
3 checks passed
@nberth nberth deleted the package-name-fix branch September 7, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilienlemaire emilienlemaire emilienlemaire approved these changes

@lefessan lefessan Awaiting requested review from lefessan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nberth @emilienlemaire