More explicitly state pointer dependencies

OGRECave · Oct 7, 2022 · 7d41cd4 · 7d41cd4
1 parent d5f5cc9
commit 7d41cd4
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/Components/Hlms/Pbs/src/Cubemaps/OgreCubemapProbe.cpp b/Components/Hlms/Pbs/src/Cubemaps/OgreCubemapProbe.cpp
@@ -115,14 +115,15 @@ namespace Ogre
         {
             if( !mCreator->getAutomaticMode() )
             {
-                if( mTexture )
+                // A Workspace without a valid texture is never valid. If it happens it
+                // could mean the workspace is internally referencing a dangling pointer.
+                OGRE_ASSERT_LOW( mTexture );
+
+                const bool useManual = mTexture->getNumMipmaps() > 1u;
+                if( useManual )
                 {
-                    const bool useManual = mTexture->getNumMipmaps() > 1u;
-                    if( useManual )
-                    {
-                        TextureGpu *channel = mWorkspace->getExternalRenderTargets()[0];
-                        mCreator->releaseTmpRtt( channel );
-                    }
+                    TextureGpu *channel = mWorkspace->getExternalRenderTargets()[0];
+                    mCreator->releaseTmpRtt( channel );
                 }
             }