Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the process if more than one log entry was found. #782

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

james-cockayne-ad
Copy link

Fix defect where if the Achilles log file contains one or more run ERROR: no runtime found in log file is recorded to the achilles_results table. Fix is to halt the process if this condition occurs and warn the user to delete the log file first.

Ideally we wouldn't be reading back from our own log files, but at least with this tweak the process won't fail silently anymore.

In the event that we spot more than one performance log entry, we will print this error and quit.

image

Previously, without this tweak we would get these results
image

I can supply a log file if needed to recreate this issue if needed.

@james-cockayne-ad
Copy link
Author

Linked to issue #745

@james-cockayne-ad
Copy link
Author

@fdefalco @MaximMoinat please could you review. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant