Skip to content

Commit

Permalink
Adjust hover over and carry changes into IR generation display
Browse files Browse the repository at this point in the history
  • Loading branch information
anthonysena committed Nov 11, 2024
1 parent 81f7bf4 commit 3074d36
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 6 deletions.
5 changes: 4 additions & 1 deletion js/pages/cohort-definitions/cohort-definition-manager.css
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,12 @@ table.sources-table tr {
table.sources-table tr:hover {
background-color: #f2f2f2;
}
table.sources-table tr:hover td {
border-top: solid 1px #ccc;
border-bottom: solid 1px #ccc;
}
table.sources-table tbody td {
padding: 0 10px 4px;
border-bottom: solid 1px #ccc;
}
.generation-buttons {
white-space: nowrap;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,10 @@ define([
this.showOnlySourcesWithResults = ko.observable(false);
this.sourcesTableOptions = commonUtils.getTableOptions('S');
this.sourcesColumns = [{
sortable: false,
className: 'generation-buttons-column',
render: () => `<span data-bind="template: { name: 'generation-buttons', data: $data }"></span>`
}, {
title: ko.i18n('cohortDefinitions.cohortDefinitionManager.panels.sourceName', 'Source Name'),
render: (s,p,d) => `${d.source.sourceName}`
}, {
Expand Down Expand Up @@ -144,10 +148,6 @@ define([
}, {
title: ko.i18n('ir.results.duration', 'Duration'),
render: (s,p,d) => d.info() ? `${this.msToTime(d.info().executionInfo.executionDuration)}` : `n/a`
}, {
sortable: false,
className: 'generation-buttons-column',
render: () => `<span data-bind="template: { name: 'generation-buttons', data: $data }"></span>`
}];
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,18 @@
tbody tr td {
padding: 0 10px 4px;
}
tr {
transition: background-color 0.3s ease; /* Smooth transition for hover effect */
}
tr:hover {
background-color: #f2f2f2;
}
tr:hover td {
border-top: solid 1px #ccc;
border-bottom: solid 1px #ccc;
}
.generation-buttons-column {
text-align: right;
text-align: left;
}
.generation-buttons {
white-space: nowrap;
Expand Down

0 comments on commit 3074d36

Please sign in to comment.