Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.3.0 #1096

Open
wants to merge 36 commits into
base: main
Choose a base branch
from
Open

Release v3.3.0 #1096

wants to merge 36 commits into from

Conversation

azimov
Copy link
Collaborator

@azimov azimov commented Nov 16, 2023

This release resolves a large number of issues with the package but will Require a cohort generator release first for the sampling functionality (which should greatly speed up phenotype development).

* FIx for namespace of characterization_view

* Update server.R
* Added forced removal of cohorts with 0 counts from cohort definition set before analysis steps

* Updated version number

* Added utility to shiny deploy and updated shiny app aspects to enforce OhdsiShinyModules 2.0.0

* Added code to run on sampled cohorts

* removed debug code

* rcheck changes

* fixes for errors and warnings

* removal of warning

* nchar fix for null sql

* have cohort concept sets function exit cleanly

* Fix for empty concept sets returned

* Fix for empty concept sets returned

* Fix exported null concepts in included_source_concept result

* Fix exported null concepts in included_source_concept result

* renamed migration file

* renamed migration files

* Fixes for export and migration of source concepts

* Package Maintenance

* removed broken migrations

* concept_id instead of 0 where not set
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: Patch coverage is 72.00000% with 49 lines in your changes missing coverage. Please review.

Project coverage is 88.59%. Comparing base (03c40ab) to head (4bb2535).

Current head 4bb2535 differs from pull request most recent head 3c706c2

Please upload reports for the commit 3c706c2 to get more accurate results.

Files Patch % Lines
R/Shiny.R 4.16% 46 Missing ⚠️
R/CohortCharacterizationDiagnostics.R 91.30% 2 Missing ⚠️
R/CohortRelationship.R 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
- Coverage   90.34%   88.59%   -1.76%     
==========================================
  Files          19       19              
  Lines        3606     3666      +60     
==========================================
- Hits         3258     3248      -10     
- Misses        348      418      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

azimov and others added 22 commits November 17, 2023 10:57
# Conflicts:
#	DESCRIPTION
#	NEWS.md
#	R/CohortCharacterizationDiagnostics.R
#	docs/404.html
#	docs/articles/CreatingAStudyPackage.html
#	docs/articles/DatabaseModeInDiagnosticsExplorer.html
#	docs/articles/RunningCohortDiagnostics.html
#	docs/articles/ViewingResultsUsingDiagnosticsExplorer.html
#	docs/articles/WhatIsCohortDiagnostics.html
#	docs/articles/index.html
#	docs/authors.html
#	docs/index.html
#	docs/news/index.html
#	docs/pkgdown.yml
#	docs/reference/CohortDiagnostics-package.html
#	docs/reference/checkInputFileEncoding.html
#	docs/reference/createDiagnosticsExplorerZip.html
#	docs/reference/createMergedResultsFile.html
#	docs/reference/createResultsDataModel.html
#	docs/reference/executeDiagnostics.html
#	docs/reference/getCdmDataSourceInformation.html
#	docs/reference/getCohortCounts.html
#	docs/reference/getDataMigrator.html
#	docs/reference/getDefaultCovariateSettings.html
#	docs/reference/getDefaultVocabularyTableNames.html
#	docs/reference/getResultsDataModelSpecifications.html
#	docs/reference/index.html
#	docs/reference/launchDiagnosticsExplorer.html
#	docs/reference/migrateDataModel.html
#	docs/reference/runCohortRelationshipDiagnostics.html
#	docs/reference/runCohortTimeSeriesDiagnostics.html
#	docs/reference/uploadResults.html
#	docs/sitemap.xml
#	extras/CohortDiagnostics.pdf
#	inst/doc/RunningCohortDiagnostics.pdf
#	inst/doc/ViewingResultsUsingDiagnosticsExplorer.pdf
#	inst/doc/WhatIsCohortDiagnostics.pdf
#	inst/sql/sql_server/UpdateVersionNumber.sql
# Conflicts:
#	DESCRIPTION
#	NEWS.md
#	docs/404.html
#	docs/articles/CreatingAStudyPackage.html
#	docs/articles/DatabaseModeInDiagnosticsExplorer.html
#	docs/articles/RunningCohortDiagnostics.html
#	docs/articles/ViewingResultsUsingDiagnosticsExplorer.html
#	docs/articles/WhatIsCohortDiagnostics.html
#	docs/articles/index.html
#	docs/authors.html
#	docs/index.html
#	docs/news/index.html
#	docs/pkgdown.yml
#	docs/reference/CohortDiagnostics-package.html
#	docs/reference/checkInputFileEncoding.html
#	docs/reference/createDiagnosticsExplorerZip.html
#	docs/reference/createMergedResultsFile.html
#	docs/reference/createResultsDataModel.html
#	docs/reference/executeDiagnostics.html
#	docs/reference/getCdmDataSourceInformation.html
#	docs/reference/getCohortCounts.html
#	docs/reference/getDataMigrator.html
#	docs/reference/getDefaultCovariateSettings.html
#	docs/reference/getDefaultVocabularyTableNames.html
#	docs/reference/getResultsDataModelSpecifications.html
#	docs/reference/index.html
#	docs/reference/launchDiagnosticsExplorer.html
#	docs/reference/migrateDataModel.html
#	docs/reference/runCohortRelationshipDiagnostics.html
#	docs/reference/runCohortTimeSeriesDiagnostics.html
#	docs/reference/uploadResults.html
#	docs/sitemap.xml
#	extras/CohortDiagnostics.pdf
#	inst/doc/RunningCohortDiagnostics.pdf
#	inst/doc/ViewingResultsUsingDiagnosticsExplorer.pdf
#	inst/doc/WhatIsCohortDiagnostics.pdf
#	inst/sql/sql_server/UpdateVersionNumber.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant