-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v3.3.0 #1096
Open
azimov
wants to merge
36
commits into
main
Choose a base branch
from
develop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Release v3.3.0 #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FIx for namespace of characterization_view * Update server.R
* Added forced removal of cohorts with 0 counts from cohort definition set before analysis steps * Updated version number * Added utility to shiny deploy and updated shiny app aspects to enforce OhdsiShinyModules 2.0.0 * Added code to run on sampled cohorts * removed debug code * rcheck changes * fixes for errors and warnings * removal of warning * nchar fix for null sql * have cohort concept sets function exit cleanly * Fix for empty concept sets returned * Fix for empty concept sets returned * Fix exported null concepts in included_source_concept result * Fix exported null concepts in included_source_concept result * renamed migration file * renamed migration files * Fixes for export and migration of source concepts * Package Maintenance * removed broken migrations * concept_id instead of 0 where not set
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
- Coverage 90.34% 88.59% -1.76%
==========================================
Files 19 19
Lines 3606 3666 +60
==========================================
- Hits 3258 3248 -10
- Misses 348 418 +70 ☔ View full report in Codecov by Sentry. |
# Conflicts: # DESCRIPTION # NEWS.md # R/CohortCharacterizationDiagnostics.R # docs/404.html # docs/articles/CreatingAStudyPackage.html # docs/articles/DatabaseModeInDiagnosticsExplorer.html # docs/articles/RunningCohortDiagnostics.html # docs/articles/ViewingResultsUsingDiagnosticsExplorer.html # docs/articles/WhatIsCohortDiagnostics.html # docs/articles/index.html # docs/authors.html # docs/index.html # docs/news/index.html # docs/pkgdown.yml # docs/reference/CohortDiagnostics-package.html # docs/reference/checkInputFileEncoding.html # docs/reference/createDiagnosticsExplorerZip.html # docs/reference/createMergedResultsFile.html # docs/reference/createResultsDataModel.html # docs/reference/executeDiagnostics.html # docs/reference/getCdmDataSourceInformation.html # docs/reference/getCohortCounts.html # docs/reference/getDataMigrator.html # docs/reference/getDefaultCovariateSettings.html # docs/reference/getDefaultVocabularyTableNames.html # docs/reference/getResultsDataModelSpecifications.html # docs/reference/index.html # docs/reference/launchDiagnosticsExplorer.html # docs/reference/migrateDataModel.html # docs/reference/runCohortRelationshipDiagnostics.html # docs/reference/runCohortTimeSeriesDiagnostics.html # docs/reference/uploadResults.html # docs/sitemap.xml # extras/CohortDiagnostics.pdf # inst/doc/RunningCohortDiagnostics.pdf # inst/doc/ViewingResultsUsingDiagnosticsExplorer.pdf # inst/doc/WhatIsCohortDiagnostics.pdf # inst/sql/sql_server/UpdateVersionNumber.sql
# Conflicts: # DESCRIPTION # NEWS.md # docs/404.html # docs/articles/CreatingAStudyPackage.html # docs/articles/DatabaseModeInDiagnosticsExplorer.html # docs/articles/RunningCohortDiagnostics.html # docs/articles/ViewingResultsUsingDiagnosticsExplorer.html # docs/articles/WhatIsCohortDiagnostics.html # docs/articles/index.html # docs/authors.html # docs/index.html # docs/news/index.html # docs/pkgdown.yml # docs/reference/CohortDiagnostics-package.html # docs/reference/checkInputFileEncoding.html # docs/reference/createDiagnosticsExplorerZip.html # docs/reference/createMergedResultsFile.html # docs/reference/createResultsDataModel.html # docs/reference/executeDiagnostics.html # docs/reference/getCdmDataSourceInformation.html # docs/reference/getCohortCounts.html # docs/reference/getDataMigrator.html # docs/reference/getDefaultCovariateSettings.html # docs/reference/getDefaultVocabularyTableNames.html # docs/reference/getResultsDataModelSpecifications.html # docs/reference/index.html # docs/reference/launchDiagnosticsExplorer.html # docs/reference/migrateDataModel.html # docs/reference/runCohortRelationshipDiagnostics.html # docs/reference/runCohortTimeSeriesDiagnostics.html # docs/reference/uploadResults.html # docs/sitemap.xml # extras/CohortDiagnostics.pdf # inst/doc/RunningCohortDiagnostics.pdf # inst/doc/ViewingResultsUsingDiagnosticsExplorer.pdf # inst/doc/WhatIsCohortDiagnostics.pdf # inst/sql/sql_server/UpdateVersionNumber.sql
…g characterization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release resolves a large number of issues with the package but will Require a cohort generator release first for the sampling functionality (which should greatly speed up phenotype development).