New function to subset results #937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azimov
reviewed
Oct 25, 2022
| ), | ||
| col_types = readr::cols()) | ||
|
|
||
| if ("cohort_id" %in% colnames(dataFromZip)) { |
There was a problem hiding this comment.
I'm not sure this works for all files - what about cohort relationships?
There was a problem hiding this comment.
Should be possible to support it. But you think this function is useful and want to add to the package?
There was a problem hiding this comment.
cohort Relationship has cohort_id - so it should work like any other table correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a function i have found useful.
Use case: During phenotype development and evaluation we develop and evaluate many candidate cohort definitions. But after the process is complete - we reject many cohorts and just want to remove them. We do not intend them to be shared for various reasons.
This function, takes a previously computed cohort diagnostics output and subsets it to a set of cohortIds given by the user, creates a new zip file that can then be shared.
If this is a useful function, but requires some changes - please feel free to make changes .