Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for RedShift were failing while evaluating changes made in #107. Upon review, I found that there is a difference in behavior when using the latest version of DatabaseConnector (v6.3.2) which is what is used when Strategus is installed for GHA testing vs the version of DatabaseConnector (v6.2.3) that was used in the test module included with Strategus. In the new version of DatabaseConnector, the RedShift driver is downloaded from
https://s3.amazonaws.com/redshift-downloads/drivers/jdbc/2.1.0.20/redshift-jdbc42-2.1.0.20.zip
. Attempts to connect to RedShift with this driver using DatabaseConnector (v6.3.2) are successful. However, when the module attempted to connect to RedShift using this driver, the following error is raised:The difference here is related in the search used to find the relevant driver:
DatabaseConnector v6.2.3:
jarPath <- findPathToJar("^RedshiftJDBC.*\\.jar$", connectionDetails$pathToDriver)
DatabaseConnector v6.3.2:
jarPath <- findPathToJar("^[Rr]edshift.*\\.jar$", connectionDetails$pathToDriver)
Not sure what we can do to detect/prevent this in the future but wanted to document it and potentially think through ways to prevent these types of errors in the future in a new issue.