Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PatientLevelPredictionValidationModule & ModelTransferModule #161

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

anthonysena
Copy link
Collaborator

@anthonysena anthonysena commented Sep 3, 2024

Aims to migrate the PatientLevelPredictionValidationModule & ModelTransferModule to the new Strategus v1.0 format.

This PR is lacking test cases at the moment which I plan to add with some guidance from @egillax.

anthonysena and others added 11 commits July 31, 2024 11:13
* Implementation of CohortIncidence module. (#147)
* Adjustments from testing

---------

Co-authored-by: Chris Knoll <[email protected]>
* Update Module-Characterization.R

* Removed doc string and R6 parameter

* Update Module-Characterization.R

fixed more duie to api changes

* Update Module-Characterization.R

- adding the new parameters

* Use param for minCharacterizationMean

---------

Co-authored-by: jreps <[email protected]>
Co-authored-by: Anthony Sena <[email protected]>
* Add getCdmDatabaseMetaData function and expose database metadata in
execution settings

* Add cdmHolder to databaseId hash - fixes #48
Characterization 2.0.1 was released to fix a issue where readr was loading settingId and converting it to a bigint and doing weird things.
* Sync with ES Module v0.6.2
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 94.89362% with 12 lines in your changes missing coverage. Please review.

Project coverage is 97.72%. Comparing base (84f516b) to head (55ad1b3).

Files with missing lines Patch % Lines
R/Settings.R 0.00% 7 Missing ⚠️
R/Module-PatientLevelPredictionValidation.R 97.80% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #161      +/-   ##
===========================================
- Coverage    98.16%   97.72%   -0.45%     
===========================================
  Files           14       15       +1     
  Lines         3545     3818     +273     
===========================================
+ Hits          3480     3731     +251     
- Misses          65       87      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

- removing model transfer
- updating validation module
- adding tests for validation module
@anthonysena anthonysena changed the base branch from v1.0-main to develop March 3, 2025 20:42
@anthonysena anthonysena marked this pull request as ready for review March 3, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants