-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Custom Modal component in Modal Service #4752
base: master
Are you sure you want to change the base?
feat: Add support for Custom Modal component in Modal Service #4752
Conversation
✅ Deploy Preview for ohif-dev canceled.
|
❌ Deploy Preview for ohif-platform-docs failed. Why did it fail? →
|
12fbe1e
to
f706ced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, see my comments.
Can we add some docs here https://docs.ohif.org/platform/services/ui/ui-modal-service/ that says how to use custom component?
27bb8a5
to
ee38a80
Compare
@sedghi I have updated the documentation of UIModalService. Could you please check that also? Thank you! |
Context
Changes & Results
Testing
Modal
Config
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment