htp: fixes warning about bad delimiter in URI#371
Closed
catenacyber wants to merge 1 commit intoOISF:0.5.xfrom
Closed
htp: fixes warning about bad delimiter in URI#371catenacyber wants to merge 1 commit intoOISF:0.5.xfrom
catenacyber wants to merge 1 commit intoOISF:0.5.xfrom
Conversation
| // reset bad_delim found in protocol part | ||
| bad_delim = 0; | ||
| for (size_t i = start; i < pos; i++) { | ||
| if (data[i] != 0x20 && htp_is_space(data[i])) { |
Member
There was a problem hiding this comment.
I assume 0x20 is covered by htp_is_space. Are you adding it explicitly to avoid the func call?
Member
There was a problem hiding this comment.
hmm no I guess I'm failing to understand the logic
Member
There was a problem hiding this comment.
So the goal is to set a warning if there are "spaces" in the URI other than 0x20, right?
Contributor
Author
There was a problem hiding this comment.
So the goal is to set a warning if there are "spaces" in the URI other than 0x20, right?
It looks so
I assume 0x20 is covered by htp_is_space.
Indeed, we want htp_is_space except for 0x20
With allow_space_uri, the protocol was checked for bad delimiter instead of the URI
catenacyber
force-pushed
the
htp-spaces-warning-v1
branch
from
18c4501 to
0282f0d
Compare
Merged
Member
|
Merged in #373, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With allow_space_uri, the protocol was checked for bad delimiter instead of the URI
See OISF/suricata#8134