Conversation
Closed
inashivb
reviewed
Apr 18, 2023
| alert mqtt any any -> any any (msg:"mqtt Frame 7"; frame:data; content:"|0a|"; sid:7;) | ||
|
|
||
| # At boundary test for truncated data | ||
| alert mqtt any any -> any any (msg:"mqtt Frame 8"; frame:data; content:"|51|"; sid:8;) |
Member
There was a problem hiding this comment.
Following the conversation from the last PR. ref #1172 (comment)
I meant that one byte is generally not a unique indicator of the data.
- Does
|51|only occur once in the entire pcap?- Yes. Then sure, this is good.
- No. Then, how do you know that the alert happened at the correct
|51|byte? A unique sequence is usually a much better indicator. So, you could have say three or two bytes before this|51|to make sure it is the exact sequence that you intended to match with.
inashivb
added
requires suricata pr
Collaborator
|
Suricata PR was merged |
Member
|
Hi @hsadia538 ! |
Collaborator
|
Replaced by #1365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://redmine.openinfosecfoundation.org/issues/5731
Previous PR: #1172
Describe changes:
Requires: OISF/suricata#8730