Closed
Conversation
Contributor
Author
|
Suricata PR: OISF/suricata#9893 |
jufajardini
requested changes
Nov 27, 2023
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Since there are two changes that can be seen:
- SIP over TCP
- different stats counters for sip_udp and sip_tcp
Would be good to see these should be included in the tests checks, that is:
- a check for the
protomatching on TCP - addition of check with stats and the
sip_tcpchecks
:)
Contributor
|
Replaced by: #1499 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/3351