Closed
Conversation
catenacyber
added
tests pass
Collaborator
Author
|
Should I have split the PR in 2 commits ? |
As this is an invalid tcp packet, that should not run any tx detection on it.
catenacyber
force-pushed
the
tcp-skip-not-established-v2
branch
from
34ef7cb to
587fcf2
Compare
Collaborator
Author
|
Replaced by #1644 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6775
Prerequisite for OISF/suricata#10307 and next
#1631 with enforcing to not match at pcap_cnt 7 as asked by Jason