sip: add tests for headers sticky buffers v2 #1787
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| sip_compact_form.pcap: sip_compact_form.syn | ||
| flowsynth.py -f pcap -w $@ $^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| # Test Purpose | ||
|
|
||
| Test that SIP headers with compact form are matched. | ||
|
|
||
| ## PCAP | ||
|
|
||
| This PCAP was generated with flowsynth. |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| flow default udp 1.1.1.1:5555 > 2.2.2.2:5060; | ||
| default > (content:"INVITE sip:97239287044@voip.brujula.net SIP/2.0\x0d | ||
| v: SIP/2.0/UDP 192.168.1.2:5060;branch=z9hG4bKnp104984053-44ce4a41192.168.1.2;rport\x0d | ||
| f: \"arik\" <sip:816666@voip.brurjula.net>;tag=6433ef9\x0d | ||
| t: <sip:97239287044@voip.brujula.net>\x0d | ||
| Call-ID: 105090259-446faf7a@192.168.1.2\x0d | ||
| CSeq: 1 INVITE\x0d | ||
| User-Agent: Nero SIPPS IP Phone Version 2.0.51.16\x0d | ||
| Expires: 120\x0d | ||
| Accept: application/sdp\x0d | ||
| c: application/sdp\x0d | ||
| l: 272\x0d | ||
| Contact: <sip:816666@192.168.1.2>\x0d | ||
| Max-Forwards: 70\x0d | ||
| Allow: INVITE, ACK, CANCEL, BYE, REFER, OPTIONS, NOTIFY, INFO\x0d | ||
| \x0d | ||
| v=0\x0d | ||
| o=SIPPS 105015165 105015162 IN IP4 192.168.1.2\x0d | ||
| s=SIP call\x0d | ||
| i=Session Description Protocol\x0d | ||
| u=https://www.sdp.proto\x0d | ||
| e=j.doe@example.com (Jane Doe)\x0d | ||
| p=+1 617 555-6011 (Jane Doe)\x0d | ||
| c=IN IP4 192.168.1.2\x0d | ||
| b=AS:64\x0d | ||
| t=3034423619 3042462419\x0d | ||
| r=604800 3600 0 90000\x0d | ||
| z=2882844526 -1h 2898848070 0\x0d | ||
| k=prompt\x0d | ||
| a=sendrecv\x0d | ||
| m=audio 30000 RTP/AVP 0 8 97 2 3\x0d | ||
| a=rtpmap:0 pcmu/8000\x0d\x0a";); | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| alert sip any any -> any any (sip.from; content:"arik"; sid:1;) | ||
| alert sip any any -> any any (sip.to; content:"sip:"; sid:2;) | ||
| alert sip any any -> any any (sip.via; content:"SIP/2.0/UDP"; sid:3;) | ||
| alert sip any any -> any any (sip.content_type; content:"application/sdp"; sid:4;) | ||
| alert sip any any -> any any (sip.content_length; content:"272"; sid:5;) | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| pcap: sip_compact_form.pcap | ||
|
|
||
| args: | ||
| - -k none | ||
|
|
||
| requires: | ||
| min-version: 8.0.0 | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 2 | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 3 | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 4 | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Match on SIP Content-Length header field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| alert sip any any -> any any (flow:to_server; sip.content_length; content:"270"; sid:1;) | ||
| alert sip any any -> any any (flow:to_client; sip.content_length; content:"199"; sid:2;) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| pcap: ../sip-method/sip.pcap | ||
|
|
||
| args: | ||
| - -k none | ||
|
|
||
| requires: | ||
| min-version: 8.0.0 | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 8 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Match on SIP Content-Type header field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| alert sip any any -> any any (flow:to_server; sip.content_type; content:"application/sdp"; sid:1;) | ||
| alert sip any any -> any any (flow:to_client; sip.content_type; content:"application/sdp"; sid:2;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| pcap: ../sip-method/sip.pcap | ||
|
|
||
| args: | ||
| - -k none | ||
|
|
||
| requires: | ||
| min-version: 8.0.0 | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 11 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 | ||
| - filter: | ||
| count: 1 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Match on SIP From header field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| alert sip any any -> any any (flow:to_server; sip.from; content:"sip:"; sid:1;) | ||
| alert sip any any -> any any (flow:to_client; sip.from; content:"sip:"; sid:2;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| pcap: ../sip-method/sip.pcap | ||
|
|
||
| args: | ||
| - -k none | ||
|
|
||
| requires: | ||
| min-version: 8.0.0 | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 47 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 | ||
| - filter: | ||
| count: 34 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Match on SIP To header field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| alert sip any any -> any any (flow:to_server; sip.to; content:"sip:"; sid:1;) | ||
|
Collaborator
There was a problem hiding this comment. Could we have a more precise content ? This looks a bit too generic... |
||
| alert sip any any -> any any (flow:to_client; sip.to; content:"sip:"; sid:2;) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| pcap: ../sip-method/sip.pcap | ||
|
|
||
| args: | ||
| - -k none | ||
|
|
||
| requires: | ||
| min-version: 8.0.0 | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 47 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 | ||
| - filter: | ||
| count: 34 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Match on SIP User-Agent header field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| alert sip any any -> any any (flow:to_server; sip.user_agent; content:"Nero"; sid:1;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| pcap: ../sip-method/sip.pcap | ||
|
|
||
| args: | ||
| - -k none | ||
|
|
||
| requires: | ||
| min-version: 8.0.0 | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 40 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Match on SIP Via header field. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| alert sip any any -> any any (flow:to_server; sip.via; content:"SIP/2.0/UDP"; sid:1;) | ||
| alert sip any any -> any any (flow:to_client; sip.via; content:"SIP/2.0/UDP"; sid:2;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| pcap: ../sip-method/sip.pcap | ||
|
|
||
| args: | ||
| - -k none | ||
|
|
||
| requires: | ||
| min-version: 8.0.0 | ||
|
|
||
| checks: | ||
| - filter: | ||
| count: 47 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 1 | ||
| - filter: | ||
| count: 34 | ||
| match: | ||
| event_type: alert | ||
| alert.signature_id: 2 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we try to convert it to an integer ?