Detect dynamic register keywords 4683 v1#1804
Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
Closed
Detect dynamic register keywords 4683 v1#1804catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
catenacyber
added
requires suricata pr
as was done by unit test DetectSNMPCommunityTest
catenacyber
force-pushed
the
detect-dynamic-register-keywords-4683-v1
branch
from
c0e367d to
e5504ea
Compare
catenacyber
added
tests pass
victorjulien
approved these changes
May 2, 2024
Merged
Member
|
Merged in #1804, thanks! |
Collaborator
Author
|
Removal of corresponding C unit test in OISF/suricata#11020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: none
@jufajardini is there a redmine ticket for moving unit test to SV ?