tests/imap-detection: add simple test for protocol detection - v6#1879
Closed
mmaatuq wants to merge 1 commit intoOISF:masterfrom
Closed
tests/imap-detection: add simple test for protocol detection - v6#1879mmaatuq wants to merge 1 commit intoOISF:masterfrom
mmaatuq wants to merge 1 commit intoOISF:masterfrom
Conversation
ticket OISF#2886 Signed-off-by: mmmaatuq <mahmoudmatook.mm@gmail.com>
3 tasks
catenacyber
approved these changes
Jun 11, 2024
Collaborator
catenacyber
left a comment
catenacyber
left a comment
There was a problem hiding this comment.
SV test looks good to me to show imap detection
catenacyber
reviewed
Jun 11, 2024
| tcp.state: closed | ||
| tcp.syn: true | ||
| tcp.tc_max_regions: 1 | ||
| tcp.tcp_flags: 1b |
Collaborator
There was a problem hiding this comment.
Nit : we do not need to test all these details
Contributor
Author
There was a problem hiding this comment.
Nit : we do not need to test all these details
should i also remove all tcp-related details?
like
- tcp.ack: true
- tcp.fin: true
- tcp.psh: true
- tcp.state: closed
- tcp.syn: true
- tcp.tc_max_regions: 1
- tcp.tcp_flags: 1b
- tcp.tcp_flags_tc: 1b
- tcp.tcp_flags_ts: 1b
- tcp.ts_max_regions: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket #2886
Redmine ticket: imap protocol detection is incomplete
Relates to this PR
changes from PR #1819 : rebase to latest master.