Skip to content

test: add test for vlan.id - v5#2183

Closed
AkakiAlice wants to merge 1 commit intoOISF:masterfrom
AkakiAlice:detect-vlan-id-1065-v5
Closed

test: add test for vlan.id - v5#2183
AkakiAlice wants to merge 1 commit intoOISF:masterfrom
AkakiAlice:detect-vlan-id-1065-v5

Conversation

@AkakiAlice
Copy link
Contributor

@AkakiAlice AkakiAlice commented Dec 12, 2024

Ticket: #1065

Description:

  • Add Suricata-Verify test for vlan.id keyword

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/1065

Previous PR: #2176
Suricata PR: OISF/suricata#12273

alert ip any any -> any any (msg:"Vlan ID is equal to 300 with specific layer"; vlan.id:0x12C,1; sid:4;)
alert ip any any -> any any (msg:"Vlan ID at layer 1 is not equal to 200"; vlan.id:!200,1; sid:5;)
alert ip any any -> any any (msg:"There is no VLAN ID equal to 500"; vlan.id:!500; sid:6;)
alert ip any any -> any any (msg:"VLAN ID at layer 2 is between 100 and 600"; vlan.id:100-600; sid:7;)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss ,2 if it states at layer 2 right ?

alert ip any any -> any any (msg:"Vlan ID at layer 1 is not equal to 200"; vlan.id:!200,1; sid:5;)
alert ip any any -> any any (msg:"There is no VLAN ID equal to 500"; vlan.id:!500; sid:6;)
alert ip any any -> any any (msg:"VLAN ID at layer 2 is between 100 and 600"; vlan.id:100-600; sid:7;)
alert ip any any -> any any (msg:"VLAN ID at layer 1 is less than 400"; vlan.id:<400; sid:8;)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss ,1 if it states at layer 1 right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants