Closed
Conversation
5 tasks
Collaborator
|
Could you please indicate the changes when you push a new PR ? |
catenacyber
reviewed
Dec 17, 2024
| alert ip any any -> any any (msg:"Last Vlan ID is equal to 400"; vlan.id:400,-1; sid:3;) | ||
| alert ip any any -> any any (msg:"Vlan ID is equal to 300 with specific layer"; vlan.id:0x12C,1; sid:4;) | ||
| alert ip any any -> any any (msg:"Vlan ID at layer 1 is not equal to 200"; vlan.id:!200,1; sid:5;) | ||
| alert ip any any -> any any (msg:"There is no VLAN ID equal to 500"; vlan.id:!500; sid:6;) |
Collaborator
There was a problem hiding this comment.
Tests look good overall
But this sig is confusing msg:"There is no VLAN ID equal to 500" should be vlan.id:!500, all
Makes me think we could also add some negative tests : add signatures that do not match like vlan.id:!300, all (even if vlan.id:!300 matches)
This would highlight the feature of all
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #1065
Description:
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/1065
Previous PR: #2185
Suricata PR:OISF/suricata#12290