Closed
Conversation
catenacyber
reviewed
Dec 24, 2024
Collaborator
|
Do not forget to add the label |
catenacyber
reviewed
Dec 24, 2024
Collaborator
|
Requires OISF/suricata#12301 |
Contributor
Author
Did you mean the link to the Suricata PR? I don't know if I have permission to add labels |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: #1065
Description:
README.md
Reduce the number of characters per line: line 1;
Add link for redmine ticket: line 6.
test.rules
Add rule with prefilter option: line 12;
Add rule for packet with 0 VLAN layers: line 13;
test.yaml
include alert for the added rules: line 67, line 72.
writepcap.py
Add a comment with scapy version: line 2;
Create a packet without VLAN layers: ine 18, line 20.
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/1065
Previous PR: #2194
Suricata PR: OISF/suricata#12301