tests: some overlapping ipv4 fragments are reassembled with a data hole#2909
Open
laubard wants to merge 1 commit intoOISF:masterfrom
Open
tests: some overlapping ipv4 fragments are reassembled with a data hole#2909laubard wants to merge 1 commit intoOISF:masterfrom
laubard wants to merge 1 commit intoOISF:masterfrom
Conversation
catenacyber
reviewed
Feb 12, 2026
|
|
||
| checks: | ||
| - shell: | ||
| args: grep '"payload_printable":".*\.\.\.\.\.\.\.\..*"' eve.json | wc -l | xargs |
Collaborator
There was a problem hiding this comment.
Why do you need a shell check instead of a filter one ?
Collaborator
|
@jasonish the tickets are closed and were yours, what do you think ? |
Member
|
Thanks @laubard. Due to some time off I probably won't get to full review along with the code for a week or so. In the mean time, could you add a |
jufajardini
requested changes
Feb 27, 2026
Contributor
jufajardini
left a comment
jufajardini
left a comment
There was a problem hiding this comment.
Changing the status as per Jason's comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://redmine.openinfosecfoundation.org/issues/6668 and https://redmine.openinfosecfoundation.org/issues/6673 issues