misc: cleanup requires inside checks - v1#2938
Open
jasonish wants to merge 3 commits intoOISF:masterfrom
Open
Conversation
- Move require expressions in shell check to requires object - Error if an unknown key is provided in a shell check
- Move require expressions in filter check to requires object - Error if an unknown key is provided in a filter check
Member
Author
|
Build against Suricata |
jasonish
commented
Mar 1, 2026
| gt-version: 8.0.4 | ||
| requires: | ||
| lt-version: 8.0.4 | ||
| gt-version: 8.0.4 |
Member
Author
There was a problem hiding this comment.
This looks like an impossible condition, however not new with this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filters that prevent a check from running should be inside a requires block as
this is what is documented in the README.