tests: test for filestore fd exhaustion - #3160
Merged
Merged
Conversation
Test that we don't leak file descriptors when configured to not keep any open.
Collaborator
|
Is this meant to pass @jasonish ? |
Member
Author
Yes. It tests a regression in one version of OISF/suricata#15634, and should prevent that regression from happening again. |
Collaborator
|
Test does not fail locally at 8a4eea4 for me |
Member
Author
It fails on this PR: OISF/suricata#15607 But the idea is still sound. That PR started to leak file descriptors, and we didn't have a test to catch that. This test will ensure future refactors won't. |
catenacyber
approved these changes
Jun 17, 2026
catenacyber
left a comment
catenacyber
left a comment
Collaborator
There was a problem hiding this comment.
Looks good thanks Jason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test that we don't leak file descriptors when configured to not keep any
open.