Closed
Conversation
So that we can write enip.revision: 0x203 Ticket: 6645
catenacyber
force-pushed
the
detect-integers-6444-v1
branch
from
0c9f55a to
aa0d56e
Compare
Contributor
Author
|
Oops, I had forgotten to push latest version |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10089 +/- ##
=======================================
Coverage 82.19% 82.20%
=======================================
Files 975 975
Lines 271940 271988 +48
=======================================
+ Hits 223523 223581 +58
+ Misses 48417 48407 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 17176 |
|
Information: QA ran without warnings. Pipeline 17178 |
This was referenced Jan 2, 2024
Closed
Contributor
Author
|
Replaced by #10105 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6645
https://redmine.openinfosecfoundation.org/issues/6646
Both in tracking ticket https://redmine.openinfosecfoundation.org/issues/6644 for integers as first-class detection
Describe changes:
Commits from #10073 and #10083 now with their own ticket into the a tracking ticket for integers as first-class detection