mqtt: Improve handling of multiple PDU parsing#10107
Closed
jlucovsky wants to merge 1 commit intoOISF:masterfrom
Closed
mqtt: Improve handling of multiple PDU parsing#10107jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky wants to merge 1 commit intoOISF:masterfrom
Conversation
Contributor
|
Could you have a SV test ? Maybe adding |
|
Information: QA ran without warnings. Pipeline 17328 |
catenacyber
reviewed
Jan 18, 2024
| input, | ||
| input.len() as i64, | ||
| current, | ||
| current.len() as i64, |
Contributor
There was a problem hiding this comment.
This should not be current.len() as current may hold multiple PDUs, but rather start.len() - rem.len()
catenacyber
requested changes
Jan 18, 2024
Contributor
catenacyber
left a comment
There was a problem hiding this comment.
CI needs to be green as well
Contributor
Author
|
Continued in #10236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: 6592
Link to redmine ticket: 6592
Describe changes:
Provide values to any of the below to override the defaults.
To use a pull request use a branch name like
pr/NwhereNis thepull request number.
Alternatively,
SV_BRANCHmay also be a link to anOISF/suricata-verify pull-request.