Skip to content

mqtt: Improve handling of multiple PDU parsing#10107

Closed
jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky:6592/1
Closed

mqtt: Improve handling of multiple PDU parsing#10107
jlucovsky wants to merge 1 commit intoOISF:masterfrom
jlucovsky:6592/1

Conversation

@jlucovsky
Copy link
Contributor

Issue: 6592

Link to redmine ticket: 6592

Describe changes:

  • Parse PDU instead of entire stream

Provide values to any of the below to override the defaults.

To use a pull request use a branch name like pr/N where N is the
pull request number.

Alternatively, SV_BRANCH may also be a link to an
OISF/suricata-verify pull-request.

SV_REPO=
SV_BRANCH=
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=

@jlucovsky jlucovsky requested a review from jasonish as a code owner January 3, 2024 14:30
@jlucovsky jlucovsky requested a review from catenacyber January 3, 2024 14:30
@catenacyber
Copy link
Contributor

Could you have a SV test ? Maybe adding bsize To the current mqtt-frames test ?

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17328

input,
input.len() as i64,
current,
current.len() as i64,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be current.len() as current may hold multiple PDUs, but rather start.len() - rem.len()

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI needs to be green as well

@jlucovsky
Copy link
Contributor Author

Continued in #10236

@jlucovsky jlucovsky closed this Jan 24, 2024
@jlucovsky jlucovsky deleted the 6592/1 branch April 24, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants