Skip to content

Comments

Dns over http2 5773 v3#10114

Closed
catenacyber wants to merge 6 commits intoOISF:masterfrom
catenacyber:dns-over-http2-5773-v3
Closed

Dns over http2 5773 v3#10114
catenacyber wants to merge 6 commits intoOISF:masterfrom
catenacyber:dns-over-http2-5773-v3

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5773

Describe changes:

  • analyze DNS over HTTP2
SV_BRANCH=pr/1540

OISF/suricata-verify#1540 rebased and force-pushed

Draft to get feedback about approach...
Leaving comments on the code for specific questions

#10040 with

  • needed rebase
  • do not parse if doh2 is disabled in suricata.yaml
  • log so that CI should not be red for the moment

TODO :

Functionnaly, in terms of output :

  • The flow will have doh2 as app_proto (and http2 as app_proto_orig)
  • There are doh2 events that have both http2 and dns fields. dns logging is done like alerts, not like dns events...
  • DNS and HTTP and HTTP2 signatures work on DOH2
  • Signatures can be DOH2 specific. These signatures can combine http, http2 and dns keywords.
  • DNS Frames do not work on DoH2

Memory management

  • a HTTP2 tx can own 2 DNS tx (one to client, one to server)
  • a HTTP2 tx stores the streamed DNS response content until it is complete before parsing it (limiting to U16_MAX bytes)

API

  • There is a new DOH2 app-layer protocol which resorts to HTTP2 for most of the things
  • HTTP2 parsing discovering DOH2 changes the app_proto to DOH2, doh2 can be enabled or disabled in suricata.yaml config
  • There are more alproto "comparison" functions
  • Every DNS keyword needs to check the flow alproto to change the transaction
  • Every DNS/HTTP keyword is automatically registered for DOH2 (hacking DetectAppLayerMpmRegister2...)

by making tx parsing and creation more easily available,
without needing a dns state.

Dns event NotResponse is now set on the right tx, and not the one
before.

Also debug log for Z-flag on request says "request" instead of
"response"

Also rustfmt dns.rs
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17339

@catenacyber
Copy link
Contributor Author

Replaced by #10123

@catenacyber catenacyber closed this Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants