Conversation
|
NOTE: This PR may contain new authors. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #10128 +/- ##
==========================================
- Coverage 82.15% 82.13% -0.02%
==========================================
Files 974 974
Lines 271925 271925
==========================================
- Hits 223394 223340 -54
- Misses 48531 48585 +54
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Can you also create a ticket, then reference the ticket in the commit and generally add the description in the PR into the commit message? Additionally, a test case for Suricata-Verify would be great. Thanks! |
Sorry, I cant create a account in Suricata issues website (I have not received the registration code in my Outlook email when I created the account) for creating a ticket which as the basis for this commit. I think you can complete all the status codes that an SMTP server might support, to avoid interruption of stream. |
catenacyber
left a comment
There was a problem hiding this comment.
Summing up for Github status : needs a better commit message and some SV test
|
Superseded by #11193 |
Make sure these boxes are signed before submitting your Pull Request -- thank you.
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Link to redmine ticket:
Describe changes: