Skip to content

smtp: Add 535 Code#10128

Closed
coalooball wants to merge 1 commit intoOISF:masterfrom
coalooball:smtp-add-535-code
Closed

smtp: Add 535 Code#10128
coalooball wants to merge 1 commit intoOISF:masterfrom
coalooball:smtp-add-535-code

Conversation

@coalooball
Copy link

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket:

Describe changes:

  • I add SMTP_REPLY_535 in app-layer-smtp.c cause some SMTP server allow multiple AUTH LOGIN. The entire session flow will be interrupted when a AUTH LOGIN failure is encountered if the 535 status code is considered illegal.

@coalooball coalooball changed the title Add 535 Code smtp:Add 535 Code Jan 6, 2024
@coalooball coalooball changed the title smtp:Add 535 Code smtp: Add 535 Code Jan 6, 2024
@github-actions
Copy link

github-actions bot commented Jan 6, 2024

NOTE: This PR may contain new authors.

@codecov
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a37fa62) 82.15% compared to head (34f6487) 82.13%.
Report is 39 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10128      +/-   ##
==========================================
- Coverage   82.15%   82.13%   -0.02%     
==========================================
  Files         974      974              
  Lines      271925   271925              
==========================================
- Hits       223394   223340      -54     
- Misses      48531    48585      +54     
Flag Coverage Δ
fuzzcorpus 62.89% <ø> (+<0.01%) ⬆️
suricata-verify 61.42% <ø> (-0.03%) ⬇️
unittests 62.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@inashivb inashivb self-assigned this Jan 8, 2024
@victorjulien victorjulien added needs ticket Needs (link to) redmine ticket needs verify Needs (a) Suricata-verify test(s) labels Jan 9, 2024
@victorjulien
Copy link
Member

Can you also create a ticket, then reference the ticket in the commit and generally add the description in the PR into the commit message? Additionally, a test case for Suricata-Verify would be great. Thanks!

@coalooball
Copy link
Author

coalooball commented Jan 19, 2024

Can you also create a ticket, then reference the ticket in the commit and generally add the description in the PR into the commit message? Additionally, a test case for Suricata-Verify would be great. Thanks!

Sorry, I cant create a account in Suricata issues website (I have not received the registration code in my Outlook email when I created the account) for creating a ticket which as the basis for this commit.

I think you can complete all the status codes that an SMTP server might support, to avoid interruption of stream.

@catenacyber
Copy link
Contributor

Copy link
Contributor

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summing up for Github status : needs a better commit message and some SV test

@inashivb inashivb removed their assignment May 17, 2024
@catenacyber
Copy link
Contributor

Superseded by #11193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs ticket Needs (link to) redmine ticket needs verify Needs (a) Suricata-verify test(s)

Development

Successfully merging this pull request may close these issues.

4 participants