Skip to content

Comments

Output alert applayer v19.1#10166

Closed
catenacyber wants to merge 3 commits intoOISF:masterfrom
catenacyber:output-alert-applayer-v19.1
Closed

Output alert applayer v19.1#10166
catenacyber wants to merge 3 commits intoOISF:masterfrom
catenacyber:output-alert-applayer-v19.1

Conversation

@catenacyber
Copy link
Contributor

Link to redmine tickets:
https://redmine.openinfosecfoundation.org/issues/3827
Preliminary work for https://redmine.openinfosecfoundation.org/issues/5053

Describe changes:

  • output: unify boilerplate code (trying to become a lines-of-code neutral contributor to Suricata ;-) and rising the percentage of rust files )
  • output/dns: do not add empty app-layer metadata
  • dnp3: restrict function scope to one file

There is one behavior change for SSH switching from LOG_DIR_PACKET to LOG_DIR_FLOW
What do you think about it ?

#9870 rebased

SV_BRANCH=pr/1490

OISF/suricata-verify#1490

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 17517

@codecov
Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1dcf69b) 82.19% compared to head (a992684) 82.10%.
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10166      +/-   ##
==========================================
- Coverage   82.19%   82.10%   -0.09%     
==========================================
  Files         974      962      -12     
  Lines      271825   271435     -390     
==========================================
- Hits       223416   222855     -561     
- Misses      48409    48580     +171     
Flag Coverage Δ
fuzzcorpus 62.77% <79.52%> (-0.25%) ⬇️
suricata-verify 61.35% <98.42%> (-0.06%) ⬇️
unittests 62.92% <37.79%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@catenacyber
Copy link
Contributor Author

Replaced by #10300

@catenacyber catenacyber closed this Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants