Closed
Conversation
Fixing single_match and manual_find intertwined with SCLogDebug
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10169 +/- ##
==========================================
- Coverage 82.12% 82.11% -0.01%
==========================================
Files 975 975
Lines 271724 271693 -31
==========================================
- Hits 223151 223114 -37
- Misses 48573 48579 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
jasonish
approved these changes
Jan 17, 2024
Member
jasonish
left a comment
jasonish
left a comment
There was a problem hiding this comment.
Nice. Some debug log lost, but nothing I'm particularly concerned about.
|
ERROR: ERROR: QA failed on TREX_GENERIC_rule_time. Pipeline 17566 |
| } | ||
| } | ||
| None | ||
| return self.transactions.iter_mut().find(|tx| tx.seqnum == hdr.seqnum && tx.activityuuid == hdr.activityuuid && ((hdr.pkt_type == DCERPC_TYPE_REQUEST && !tx.req_done) || (hdr.pkt_type == DCERPC_TYPE_RESPONSE && !tx.resp_done))) |
Member
There was a problem hiding this comment.
is this rustfmt clean? Seems like an excessively long line
Contributor
Author
There was a problem hiding this comment.
Indeed, it was not...
Are you ready for #10088 after this one ?
Closed
Contributor
Author
|
Continued in #10207 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
None
Describe changes:
Follow up after merge of #10156