Closed
Conversation
So that we can write enip.revision: 0x203 Ticket: 6645
Ticket: 6647 Allows keywords using integers to use strings in signature parsing based on a rust enumeration with a derive.
Ticket: 6648 Like &0x40=0x40 to test for a specific bit set
Ticket: 6628 Document the generic detection capabilities for integer keywords. and make every integer keyword pointing to this section.
|
Information: ERROR: QA failed on SURI_TLPW1_files_sha256.
Pipeline 17729 |
Contributor
Author
|
Why is CI using libhtp 0.5.45 and not 0.5.x ? |
Member
CI uses |
jasonish
reviewed
Jan 24, 2024
|
|
||
| DHCP lease time (integer). | ||
|
|
||
| dhcp.leasetime uses an :ref:`unsigned 64-bits integer <rules-integer-keywords>`. |
Contributor
Author
There was a problem hiding this comment.
Without an s if I believe
16-bit integers are those that are 16 bits (2 octets) wide.
Fixing that
jasonish
reviewed
Jan 24, 2024
|
|
||
| /// Enum trait that will be implemented on enums that | ||
| /// derive StringEnum. | ||
| pub trait Enum<T> { |
Member
There was a problem hiding this comment.
Would EnumString be a better name?
Contributor
Author
|
Replaced by #10241 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6644 and all subtickets
https://redmine.openinfosecfoundation.org/issues/6645
https://redmine.openinfosecfoundation.org/issues/6646
https://redmine.openinfosecfoundation.org/issues/6647
https://redmine.openinfosecfoundation.org/issues/6648
https://redmine.openinfosecfoundation.org/issues/6628
Describe changes:
#10222 with typo fixed in doc