userguide: fix explanation about bsize ranges - v1#10235
Closed
jufajardini wants to merge 1 commit intoOISF:masterfrom
Closed
userguide: fix explanation about bsize ranges - v1#10235jufajardini wants to merge 1 commit intoOISF:masterfrom
jufajardini wants to merge 1 commit intoOISF:masterfrom
Conversation
Our code handles Uint ranges as exclusive, but for bsize, our
documentation stated that they're inclusive.
Cf. from uint.rs:
DetectUintMode::DetectUintModeRange => {
if val > x.arg1 && val < x.arg2 {
return true;
}
}
Task OISF#6708
Contributor
Author
|
Do I understand it correctly that before https://github.com/OISF/suricata-verify/pull/1608/files gets merged, the CI failure (https://github.com/OISF/suricata/actions/runs/7642196410/job/20824055247?pr=10235#step:14:84) is expected? |
Contributor
Author
|
replaced by: #10250 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our code handles Uint ranges as exclusive, but for bsize, our documentation stated that they're inclusive.
Cf. from uint.rs:
Task #6708
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6708
Describe changes:
bsizedocs section