detect: dns.opcode as first-class integer#10280
detect: dns.opcode as first-class integer#10280catenacyber wants to merge 1 commit intoOISF:masterfrom
Conversation
Ticket: 5446 That means it can accept ranges
catenacyber
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #10280 +/- ##
===========================================
+ Coverage 73.31% 82.32% +9.00%
===========================================
Files 895 978 +83
Lines 148215 271999 +123784
===========================================
+ Hits 108666 223912 +115246
- Misses 39549 48087 +8538
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 17946 |
| arg2: 0, | ||
| }, | ||
| 0b0010_0000_0000_0000, | ||
| ((0b0010_0000_0000_0000 >> 11) & 0xf) as u8, |
There was a problem hiding this comment.
Should we have a couple of tests for range and negative range too if they're allowed for opcode?
There was a problem hiding this comment.
Why ?
There are already tests for generic DetectUintData for range and negative range.
Feels to me like duplicating...
There was a problem hiding this comment.
ok sure. I just saw the other modes in the test here and thought it was missing.
There was a problem hiding this comment.
I just translated the existing unit tests, right ?
There was a problem hiding this comment.
yep. thought that since this PR enabled range acceptance, why was that mode missing in tests when there were others. I mean this is cool with me if there are tests already. Thanks :)
|
Merged in #10321, thanks! |
5 participants
Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/5446
Describe changes:
#10208 rebased after merge of #10246 (and updated doc to point to rules-integer-keywords)