Skip to content

Comments

doc: there is no right shift for integer bitmasks#10282

Closed
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:doc-integer-bitmask-6628-v1
Closed

doc: there is no right shift for integer bitmasks#10282
catenacyber wants to merge 1 commit intoOISF:masterfrom
catenacyber:doc-integer-bitmask-6628-v1

Conversation

@catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/6628

Describe changes:

  • doc: there is no right shift for integer bitmasks

cc @zoomequipd

Follow up on #10246 to add this precision

@catenacyber catenacyber added the typo/doc update No code change : only doc or typo fixes label Jan 30, 2024
@codecov
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (244a35d) 73.31% compared to head (3e88302) 82.31%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #10282       +/-   ##
===========================================
+ Coverage   73.31%   82.31%    +9.00%     
===========================================
  Files         895      978       +83     
  Lines      148215   272029   +123814     
===========================================
+ Hits       108666   223929   +115263     
- Misses      39549    48100     +8551     
Flag Coverage Δ
fuzzcorpus 63.47% <ø> (-0.01%) ⬇️
suricata-verify 61.48% <ø> (-0.04%) ⬇️
unittests 62.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@suricata-qa
Copy link

ERROR:

ERROR: QA failed on build_asan.

Pipeline 18597

@suricata-qa
Copy link

Information:

ERROR: QA failed on SURI_TLPW2_autofp_suri_time.

field baseline test %
SURI_TLPW2_autofp_stats_chk
.uptime 101 111 109.9%

Pipeline 18707

@catenacyber
Copy link
Contributor Author

Replaced by #10501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

typo/doc update No code change : only doc or typo fixes

Development

Successfully merging this pull request may close these issues.

4 participants